Skip to content

Re-enable "no-unused-expressions" rule for eslint - #2970

Merged
bajtos merged 1 commit into
masterfrom
fix/remove-unused-expressions
Nov 23, 2016
Merged

bajtos merged 1 commit into
masterfrom
fix/remove-unused-expressions

Conversation

@bajtos

@bajtos bajtos commented Nov 22, 2016 •

Copy link
Copy Markdown
Member

As a follow-up to #2632, I am cleaning up the use of property-based assertions (see Beware of libraries that assert on property access). The patch adds "dirty-chai" to modify chai's property checkers.

@superkhau please review
cc @loay

Fix unit-tests relying on property-based assertions to use function
calls instead, using "dirty-chai" to modify chai's property checkers.
@bajtos bajtos added the #review label Nov 22, 2016
@bajtos bajtos changed the title Turn on "no-unused-expressions" rule for eslint Re-enable "no-unused-expressions" rule for eslint Nov 22, 2016
@superkhau superkhau assigned bajtos and unassigned superkhau Nov 22, 2016
@superkhau

Copy link
Copy Markdown
Contributor

@slnode test please

@bajtos
bajtos merged commit d4bee2b into master Nov 23, 2016
@bajtos
bajtos deleted the fix/remove-unused-expressions branch November 23, 2016 09:01
@bajtos bajtos removed the #review label Nov 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants