Repository navigation
Re-enable "no-unused-expressions" rule for eslint - #2970
Merged
Merged
Conversation
Fix unit-tests relying on property-based assertions to use function calls instead, using "dirty-chai" to modify chai's property checkers.
superkhau
approved these changes
Nov 22, 2016
Contributor
|
@slnode test please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a follow-up to #2632, I am cleaning up the use of property-based assertions (see Beware of libraries that assert on property access). The patch adds "dirty-chai" to modify chai's property checkers.
@superkhau please review
cc @loay